RENAME methods for consistency

This commit is contained in:
2025-05-15 10:07:48 +02:00
committed by dylandefaoite
parent b75704ec75
commit e2c4b81cad
6 changed files with 23 additions and 15 deletions

3
.gitignore vendored
View File

@@ -32,3 +32,6 @@ build/
### VS Code ### ### VS Code ###
.vscode/ .vscode/
### Generated Files ###
videos/

View File

@@ -1,14 +1,11 @@
package com.ddf.vodsystem.controllers; package com.ddf.vodsystem.controllers;
import com.ddf.vodsystem.exceptions.JobNotFinished;
import com.ddf.vodsystem.exceptions.JobNotFound;
import com.ddf.vodsystem.services.DownloadService; import com.ddf.vodsystem.services.DownloadService;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.http.HttpHeaders; import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType; import org.springframework.http.MediaType;
import org.springframework.http.ResponseEntity; import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.ExceptionHandler;
import org.springframework.web.bind.annotation.GetMapping; import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable; import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RestController; import org.springframework.web.bind.annotation.RestController;
@@ -24,7 +21,7 @@ public class DownloadController {
@GetMapping("/download/{filename}") @GetMapping("/download/{filename}")
public ResponseEntity<Resource> downloadFile(@PathVariable String filename) { public ResponseEntity<Resource> downloadFile(@PathVariable String filename) {
Resource resource = downloadService.download(filename); Resource resource = downloadService.downloadOutput(filename);
if (resource == null || !resource.exists()) { if (resource == null || !resource.exists()) {
return ResponseEntity.notFound().build(); return ResponseEntity.notFound().build();

View File

@@ -24,7 +24,7 @@ public class EditController {
@GetMapping("/process/{uuid}") @GetMapping("/process/{uuid}")
public ResponseEntity<String> convert(@PathVariable("uuid") String uuid) { public ResponseEntity<String> convert(@PathVariable("uuid") String uuid) {
editService.jobReady(uuid); editService.process(uuid);
return new ResponseEntity<>(uuid, HttpStatus.OK); return new ResponseEntity<>(uuid, HttpStatus.OK);
} }

View File

@@ -21,7 +21,18 @@ public class DownloadService {
this.jobService = jobService; this.jobService = jobService;
} }
public Resource download(String uuid) { public Resource downloadInput(String uuid) {
Job job = jobService.get(uuid);
if (job == null) {
throw new JobNotFound("Job doesn't exist");
}
File file = job.getInputFile();
return new FileSystemResource(file);
}
public Resource downloadOutput(String uuid) {
Job job = jobService.get(uuid); Job job = jobService.get(uuid);
if (job == null) { if (job == null) {

View File

@@ -17,22 +17,18 @@ public class EditService {
public void edit(String uuid, ClipConfig clipConfig) { public void edit(String uuid, ClipConfig clipConfig) {
Job job = jobService.get(uuid); Job job = jobService.get(uuid);
if (clipConfig.getStartPoint() != null) { if (clipConfig.getStartPoint() != null && clipConfig.getStartPoint() < 0) {
if (clipConfig.getStartPoint() < 0) { throw new IllegalArgumentException("Start point cannot be negative");
throw new IllegalArgumentException("Start point cannot be negative");
}
} }
if (clipConfig.getFileSize() != null) { if (clipConfig.getFileSize() != null && clipConfig.getFileSize() < 100) {
if (clipConfig.getFileSize() < 100) { throw new IllegalArgumentException("File size cannot be less than 100kb");
throw new IllegalArgumentException("File size cannot be less than 100kb");
}
} }
job.setClipConfig(clipConfig); job.setClipConfig(clipConfig);
} }
public void jobReady(String uuid) { public void process(String uuid) {
jobService.jobReady(uuid); jobService.jobReady(uuid);
} }

View File

@@ -56,6 +56,7 @@ public class JobService {
try { try {
compressionService.run(job);// Execute the task compressionService.run(job);// Execute the task
} catch (IOException | InterruptedException e) { } catch (IOException | InterruptedException e) {
Thread.currentThread().interrupt();
logger.error("Error while running job {}", job.getUuid(), e); logger.error("Error while running job {}", job.getUuid(), e);
} }
} }